From 5c528d98e866801024e528631fe39933fcfb704a Mon Sep 17 00:00:00 2001 From: TWloYWkgQm9kbmFyaXU= Date: Mon, 1 Apr 2024 15:13:48 +0300 Subject: [PATCH] fix: apply review --- .github/workflows/v2-prepare-scoring.yml | 2 +- .github/workflows/v2-prepare-unstakes.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/v2-prepare-scoring.yml b/.github/workflows/v2-prepare-scoring.yml index ad444f1..6a926d1 100644 --- a/.github/workflows/v2-prepare-scoring.yml +++ b/.github/workflows/v2-prepare-scoring.yml @@ -79,7 +79,7 @@ jobs: git config --global user.email 'bot@noreply.marinade.finance' git checkout -b "$scoring_branch" git add scoring-v2 - ! [ -z "$(git status --porcelain)" ] && git commit -m "scoring run $scoring_id" && git push -u origin "$scoring_branch" || echo "No changes to be committed" + [[ -n "$(git status --porcelain)" ]] && git commit -m "scoring run $scoring_id" && git push -u origin "$scoring_branch" || echo "No changes to be committed" pr_url=$(gh pr create -B scoring-v2 -H "$scoring_branch" --title "Publish V2 Scoring Results ($scoring_id)" --body-file "${{ env.scoring_path }}/summary.md") echo "pr_url=$pr_url" >> $GITHUB_ENV diff --git a/.github/workflows/v2-prepare-unstakes.yml b/.github/workflows/v2-prepare-unstakes.yml index 3902e54..e287108 100644 --- a/.github/workflows/v2-prepare-unstakes.yml +++ b/.github/workflows/v2-prepare-unstakes.yml @@ -126,7 +126,7 @@ jobs: git config --global user.email 'bot@noreply.marinade.finance' git checkout -b "$scoring_branch" git add scoring-v2 - ! [ -z "$(git status --porcelain)" ] && git commit -m "emergency unstakes for scoring run $scoring_id" && git push -u origin "$scoring_branch" || echo "No changes to be committed" + [[ -n "$(git status --porcelain)" ]] && git commit -m "emergency unstakes for scoring run $scoring_id" && git push -u origin "$scoring_branch" || echo "No changes to be committed" pr_body=$(cat unstakes.md) pr_url=$(gh pr create -B scoring-v2 -H "$scoring_branch" --title "Publish V2 Emergency Unstakes ($scoring_id)" --body "$pr_body") echo "pr_url=$pr_url" >> $GITHUB_ENV