Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Duplicate state still active while new password is created #632

Closed
6 tasks done
StephaneHugues opened this issue Jan 23, 2024 · 2 comments
Closed
6 tasks done
Labels
bug Something in the app is not working as expected

Comments

@StephaneHugues
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a single bug, not a question or a configuration/webserver/proxy issue.
  • This is not a bug in the browser extension or another client.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server and the Passwords App is up to date. See Nextcloud Apps.
  • There are no warnings and errors reported in the Passwords App settings in the admin area
  • The following apps are not installed: Rainloop

Server Information

occ $ passwords:system:report debug
{
    "version": {
        "server": "27.1.4.1",
        "app": "2023.12.32",
        "lsr": false,
        "php": "8.1.25",
        "cronPhp": "8.1.25"
    },
    "environment": {
        "os": "Linux",
        "architecture": "x86_64",
        "bits": 64,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": false,
        "subdirectory": false
    },
    "services": {
        "images": "gdlib",
        "favicons": "default",
        "previews": "default",
        "security": "hibp",
        "words": "auto",
        "previewApi": false,
        "faviconApi": false
    },
    "status": {
        "autoBackupRestored": false
    },
    "settings": {
        "channel": "stable",
        "nightlies": false,
        "handbook": false,
        "performance": 5
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "SSEv3r1": false,
            "none": false,
            "default": "SSEv1r2"
        },
        "cse": {
            "CSEv1r1": false,
            "none": true,
            "default": "none"
        }
    }

Client Information

Browser and Version: Firefox 121.0.1
Client OS and Version: Windows 10 22h2

Bug description

Situation :

  • two duplicate password entry in the folder. Other fields are different
  • the second entry is deleted
  • new password is created for the first entry

Result :

  • Duplicate state still active

Again, duplicate state still active even if new password is generated while the state should be securized

Steps to reproduce

  • two duplicate password entry created in the folder. Other fields are different
  • the second entry is deleted
  • new password is created for the first entry
  • The duplicate state still active for first entry

Expected behavior

  • two duplicate password entry created in the folder. Other fields are different
  • the second entry is deleted
  • new password is created for the first entry
  • The securized state must be set for first entry

Nextcloud Logs

No response

Browser Logs

No response

@StephaneHugues StephaneHugues added the bug Something in the app is not working as expected label Jan 23, 2024
@brainchild0
Copy link

brainchild0 commented Jan 14, 2025

It seems preferable that the duplicate flagging would be cleared from a password record the moment the last record is deleted or changed that is a duplicate.

From my experience, as well as the presently reported behavior, such functionality is not currently effective.

The way the report is framed, it seems to be an expectation that duplicate flagging may be cleared for a password record only when the password in the record is changed. In fact, however, other events, not applying directly to a particular record, seem as suitable causes for its duplicate flagging being cleared.

@StephaneHugues
Copy link
Author

The problem has not reoccurred since processing all duplicate passwords.
I consider the problem solved.
Thanks for your reply

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something in the app is not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants