We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stduuid/include/uuid.h
Line 402 in 3afe719
This should be changed to
explicit uuid(span<value_type const, 16> bytes)
in order to support construction from immutable contiguous containers and it can be made constexpr in C++20 mode.
It would also be nice if we had a
CONSTEXPR20 explicit uuid(span<std::byte const, 16> bytes)
constructor for symmetry with as_bytes() -> span<std::byte const, 16> bytes.
as_bytes() -> span<std::byte const, 16> bytes
I'd be willing to implement it and update the paper if this is uncontroversial.
The text was updated successfully, but these errors were encountered:
👍 for the problem - the interface is right now inconsistent. as_bytes uses std::byte while creating a new uuid enforce casting to uint8_t.
as_bytes
std::byte
uint8_t
Sorry, something went wrong.
No branches or pull requests
stduuid/include/uuid.h
Line 402 in 3afe719
This should be changed to
in order to support construction from immutable contiguous containers and it can be made constexpr in C++20 mode.
It would also be nice if we had a
constructor for symmetry with
as_bytes() -> span<std::byte const, 16> bytes
.I'd be willing to implement it and update the paper if this is uncontroversial.
The text was updated successfully, but these errors were encountered: