Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The link "#" should be prevent for one page application. #11

Open
wind13 opened this issue Mar 13, 2016 · 2 comments
Open

The link "#" should be prevent for one page application. #11

wind13 opened this issue Mar 13, 2016 · 2 comments

Comments

@wind13
Copy link
Contributor

wind13 commented Mar 13, 2016

For one page application, the url "#" part means different route, so use this pagination will take to home page after run callback.

So it should add this code:

event.preventDefault();

in the PaginationView.prototype.clicked function.
@markbates
Copy link
Owner

Please submit a PR. Thanks.

@wind13
Copy link
Contributor Author

wind13 commented Mar 14, 2016

Okay, already submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markbates @wind13