Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in composer.json causes update to fail #38

Open
chrisdempsey opened this issue Sep 13, 2023 · 0 comments
Open

Typo in composer.json causes update to fail #38

chrisdempsey opened this issue Sep 13, 2023 · 0 comments

Comments

@chrisdempsey
Copy link

I attempted to install silverstripe-email-helpers to a project I inherited using the require command from readme.md.

composer require markguinn/silverstripe-email-helpers:dev-master

This fails with error

In RootPackageLoader.php line 160:

  require-dev.phpunit/PHPUnit is invalid, it should not contain uppercase characters. Please use phpunit/phpunit instead.

This is due to a typo in the current composer.json file in the remote silverstripe-email-helpers repository at
https://github.com/markguinn/silverstripe-email-helpers/blob/master/composer.json

Line 19 is

"phpunit/PHPUnit": "3.7.*@stable"

but should be lowercase

"phpunit/phpunit": "3.7.*@stable"

I tested this working locally by running composer update on a new project containing only the composer.json below.

Can anyone confirm this and update the github repository?

I don't think I can update the project I inherited until this is available due to the autoload and lock features as it seems likely that manually uploading the vendor directory created with the JSON below would cause a critical conflict?

{
	"name": "markguinn/silverstripe-email-helpers",
	"description": "Silverstripe extension containing SMTP mailer class and some other classes for HTML emails",
	"type": "silverstripe-module",
	"keywords": ["silverstripe", "email", "smtp", "emogrifier"],
	"authors": [
		{
			"name": "Mark Guinn",
			"homepage": "http://github.com/markguinn",
            "role": "Developer"
		}
	],
	"require": {
		"silverstripe/framework": "~3.0",
		"pelago/emogrifier": "^2.0",
		"phpmailer/phpmailer": "^5.2.20"
	},
	"require-dev": {
		"phpunit/phpunit": "3.7.*@stable"
	},
	"extra": {
		"installer-name": "email-helpers"
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant