Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Alternate method to supply appid #1

Open
jsphstls opened this issue Feb 9, 2018 · 0 comments
Open

Feature: Alternate method to supply appid #1

jsphstls opened this issue Feb 9, 2018 · 0 comments

Comments

@jsphstls
Copy link

jsphstls commented Feb 9, 2018

The appid is currently retrieved by regexing for a common pattern in F2 app creation files:
https://github.com/markitondemand/f2-manifest-loader/blob/master/src/index.js#L51-L52

Every file requires this pattern:

F2.Apps['com_open_f2_some_app']

The loader will extract com_open_f2_ignored_app as the appid. This works, but it creates limitations. These instances cannot currently be used:

const appId = 'com_open_f2_some_app'
F2.Apps[appId] = SomeApp
import APP_IDS from 'somewhere'
F2.Apps[APP_IDS.SOME_APP] = SomeApp
function createF2App (appId, App) {
  F2.Apps[appId] = App
}

Could a list of appIds were supplied directly to the loader?
Could the filename be used as the appId?

pc2459 pushed a commit that referenced this issue Aug 27, 2018
…d-filename to master

* commit '68845bcd6e9ec7bb2277a7bd041a69448ab45a94':
  Bump version to 0.2.0
  Allow users to pass in filename and app styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant