Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing tag names include trailing whitespace #174

Open
AngusMorton opened this issue Feb 20, 2024 · 0 comments
Open

Closing tag names include trailing whitespace #174

AngusMorton opened this issue Feb 20, 2024 · 0 comments

Comments

@AngusMorton
Copy link

AngusMorton commented Feb 20, 2024

The following HTML/Marko doesn't parse because the closeTagName is parsed with whitespace and so the open and close tag names don't match.

<span class="dolorum atque aspernatur"
  >Est molestiae sunt facilis qui rem.</span
>
<span class="dolorum atque aspernatur"
  >Est molestiae sunt facilis qui rem.</span
                                        ^^^^ 
       The closing "span\n" tag does not match the corresponding opening "span" tag.
>

I would expect the closeTagName to be "span" and the closeTagEnd to be "\n>"... But I don't know if that makes sense. Alternatively, we consume and discard the whitespace between closeTagName and closeTagEnd. I also don't know how this change would impact upstream dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant