Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler should filter out duplicated attrs #129

Open
LuLaValva opened this issue Jan 20, 2023 · 0 comments
Open

compiler should filter out duplicated attrs #129

LuLaValva opened this issue Jan 20, 2023 · 0 comments
Assignees
@DylanPiercey

Comments

@LuLaValva
Copy link
Member

LuLaValva commented Jan 20, 2023 •
edited by mlrawlings
Loading

x/packages/translator/src/visitors/tag/native-tag.ts

Line 156 in 86e1c04

// TODO: this should iterate backward and filter out duplicated attrs.

In HTML, first attribute value takes precendent, but Marko follows the rules of object properties (last property takes precedent), so we need to filter out duplicates to ensure the same behavior between the two.
@mlrawlings mlrawlings changed the title this should iterate backward and filter out duplicated attrs. compiler should filter out duplicated attrs Jan 10, 2024
@LuLaValva LuLaValva assigned DylanPiercey and unassigned LuLaValva Sep 30, 2024
@DylanPiercey DylanPiercey moved this from Todo to Done in The Everything Project Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DylanPiercey DylanPiercey

Labels
None yet
Projects
The Everything Project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DylanPiercey @LuLaValva