Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave position finetune #7

Open
Wilker-uwu opened this issue Sep 14, 2019 · 4 comments
Open

Wave position finetune #7

Wilker-uwu opened this issue Sep 14, 2019 · 4 comments

Comments

@Wilker-uwu
Copy link

currently, we can set the number of lines that we can have, and define the order of colors to change the position of the colors, but it would be nice to also have a position finetune slider so we can set the smaller details, to sync them with an element in the home screen, for example.

what do you think? :3

@markusfisch
Copy link
Owner

Sorry for answering so late. What kind of control do you have in mind? How should the waves sync or interact with some special spot?

@Wilker-uwu
Copy link
Author

i was just thinking of a slider next to the settings where you set up the layers of colors and positions of the colors. currently, we set up the amount of waves to adjust their sizes (when uniform height is on), and change their positions by changing the order of the colors and stuff. my use case is that sometimes i want to sync the waves with some elements on the screen, but it is hard to figure the height and how many waves makes the size and position fit in nicely. a slider for position finetune sounds simple enough (i guess)
an example screenshot of the home screen using KISS launcher. a wave in the dark wallpaper is colored in pink for highlighting, making it apparent that this was a failed attempt at making the wave stay in a proper position behind the icons.
in this background, i duplicated several black colors and put one different color in a certain wave so i could try to make some kind of toolbar background with the icons.

* the waves are flat because of the timing.
* the wave was colored pink for highlighting.

what do you think? :3

@markusfisch
Copy link
Owner

I think I understand. You want a slider to give a vertical offset for all waves, right? Of course, that would only be meaningful for uniform waves 🤔

@Wilker-uwu
Copy link
Author

Wilker-uwu commented Sep 24, 2019

yes :3

maybe without uniform waves too, but idk if it is worth it..

i guess that having the value of the slider measured relative to the default wave sizes (from -0.50w to 0.50w where w is the height of a wave on the screen in its default size (which changes with the amount of waves set)) would make it easy to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants