Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fake git driver #13

Open
markwalet opened this issue Apr 3, 2020 · 0 comments
Open

Remove the fake git driver #13

markwalet opened this issue Apr 3, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@markwalet
Copy link
Owner

Some of the unit tests depend on the FakeGitDriver, which is a helper class to make testing easier.

Right now this class is shipped in production code. And that is not intended.

With class mocking, it should be possible to remove the need of the fake driver completely. Tests should be adapted to use a mock. If it is necessary, we can also change the service provider loading structure. But this will result in a bigger update which we want to prevent.

@markwalet markwalet added the enhancement New feature or request label Apr 3, 2020
@markwalet markwalet self-assigned this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant