Fixa unit test that all csv files are comma separated

[MansMeg]

This failed my runs when @jensfinnas introduced other csv files with 9c05bfe .

[jensfinnas]

Misstag att det blev semikolon här. Den 5 feb. 2017 20:31 skrev "Måns Magnusson" <[email protected]>:

…

This failed my runs when @jensfinnas <https://github.com/jensfinnas> introduced other csv files with 9c05bfe <9c05bfe> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCgy0Hn1aXb15JpKczvXUqLf-gKkV4dks5rZiOlgaJpZM4L3mNb> .

[MansMeg]

Ingen fara. Super om vi lägger till ett unit test bara. Har revertat ditt commit.

[jensfinnas]

Jag hade en lokal commit som jag glömt att pusha. Ny mergad version ute nu. Det fanns några ändringar som fattades i din version. 2017-02-05 20:50 GMT+01:00 Måns Magnusson <[email protected]>:

…

Ingen fara. Super om vi lägger till ett unit test bara. Har revertat ditt commit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCgyyMSJrnZ7W3t0tXDlTfli0GDKlnGks5rZigXgaJpZM4L3mNb> .

-- ... Jens Finnäs Journalism++ Stockholm +46 76 901 7438 jplusplus.se

[MansMeg]

? Den failar ju nu?

[jensfinnas]

Var failar den? 2017-02-05 21:19 GMT+01:00 Måns Magnusson <[email protected]>:

…

? Den failar ju nu? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCgy-qZa-d-YUQ9tcq6PHTc9rnW-2KTks5rZi7bgaJpZM4L3mNb> .

-- ... Jens Finnäs Journalism++ Stockholm +46 76 901 7438 jplusplus.se

[MansMeg]

Se: https://travis-ci.org/marple-newsrobot/marple-datatypes =================================== FAILURES ===================================

______________________________ test_id_uniqueness ______________________________ get_datatype_files = ['misc/age_groups.csv', 'misc/crime_codes.csv', 'misc/crime_types.csv', 'misc/foreignborn.csv', 'misc/genders.csv', 'misc/house_types.csv', ...] def test_id_uniqueness(get_datatype_files): """ Test there are no id duplicates """ ids = [] for file_path in get_datatype_files: with open(file_path) as f: reader = csv.DictReader(f) ids += [ x["id"] for x in reader ] duplicates = get_duplicates(ids)

assert len(duplicates) == 0

E assert 2 == 0 E + where 2 = len(set(['', 'Hässelby-Vällingby stadsdelsområde'])) tests/test_datatype_files.py:20: AssertionError =========================== 1 failed in 0.20 seconds =========================== The command "PYTHONPATH=. py.test tests" exited with 1. Done. Your build exited with 1. 2017-02-05 21:23 GMT+01:00 Jens Finnäs <[email protected]>:

…

Var failar den? 2017-02-05 21:19 GMT+01:00 Måns Magnusson ***@***.***>: > ? Den failar ju nu? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/marple-newsrobot/marple-datatypes/ issues/1#issuecomment-277546041>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABCgy-qZa-d- YUQ9tcq6PHTc9rnW-2KTks5rZi7bgaJpZM4L3mNb> > . > -- ... Jens Finnäs Journalism++ Stockholm +46 76 901 7438 <+46%2076%20901%2074%2038> jplusplus.se — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWCVn3pXWD7y513GHHC8Aazcnc14jJnks5rZi_NgaJpZM4L3mNb> .

-- Med vänlig hälsning Måns ============================ Måns Magnusson 070 - 588 97 15 [email protected] ============================