Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove validate_spec feature #308

Closed
lafrech opened this issue Oct 8, 2018 · 5 comments · Fixed by #803
Closed

RFC: Remove validate_spec feature #308

lafrech opened this issue Oct 8, 2018 · 5 comments · Fixed by #803

Comments

@lafrech
Copy link
Member

lafrech commented Oct 8, 2018

See discussions in #299.

No strong feeling either way. Indeed, it probably works for most users, and anyone unhappy about the default values may install and call prance independently, so this implementation at least serves the purpose of showing how to do it.

@lafrech lafrech added this to the 1.0 milestone Oct 8, 2018
@sloria
Copy link
Member

sloria commented Oct 23, 2018

We can leave this issue open for discussion, but I'm going to remove this from the 1.0 milestone in the interest of cutting scope.

@sloria sloria removed this from the 1.0 milestone Oct 23, 2018
@lafrech lafrech added this to the 6.0 milestone Sep 13, 2022
@lafrech
Copy link
Member Author

lafrech commented Sep 13, 2022

Recent CI issues are due to changes in openapi_spec_validator 0.5.x, which is a dependency of prance. Until prance releases a fix, we should pin openapi_spec_validator<0.5 for the "validation" extra requires.

I wouldn't mind removing the feature from the public API and only keeping it internally for the tests. I admit this wouldn't solve the whole issue, just make it less of a problem to modify dependency versions without it being a breaking change. Also, if there hasn't been any issue in 4 years, maybe I'm overreacting.

My point is that if it is only used for the test, we are free to change versions, even the lib used internally, even remove the whole thing without notice, so it makes maintenance a bit easier.

Nobody has 👍 or 👎 since I opened this RFC so perhaps nobody cares.

@SpeeddY
Copy link

SpeeddY commented Sep 21, 2022

Just run into this issue as I went to update openapi-spec-validator to 0.5.1, was about to raise an issue here but stumbled upon this thread. ImportError: cannot import name 'validate_v2_spec' from 'openapi_spec_validator'. The prance issue: RonnyPfannschmidt/prance#131

@lafrech
Copy link
Member Author

lafrech commented Sep 21, 2022

Yes, I saw that issue. I should have linked to it. Thanks.

Does this mean you're using the feature and you're 👎 about removing it?

In practice the feature doesn't provide much more than an abstraction for the validation frameworks. Anyone can install any validator on their own.

@SpeeddY
Copy link

SpeeddY commented Sep 22, 2022

We are using the feature but it would be an easy refactor to remove it (the refactor would use the new "detecting version validate_spec" method from openapi-spec-validator)

If you go ahead with this RFC I presume you can remove the openapi-spec-validator dependency entirely?
(I am not a downvote)
If you decided to keep it, it would be great if it could work with the latest openapi-spec-validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants