Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add /novelbin.com #54

Open
feahnthor opened this issue Aug 4, 2024 · 0 comments
Open

[Enhancement] Add /novelbin.com #54

feahnthor opened this issue Aug 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@feahnthor
Copy link
Member

Add the site https://novelbin.com/.
image

This site is very similar to the novelfull.com site, therefore, you can use the current NovelFullStrategy and places novelfull is mentioned as a reference.

Tips


  1. Update the appsettings.json
    a. The new novel must be added inside of the "SiteCorfigurations" array.
    b. Follow the instructions created here How to add new Site to Benny-Scraper for getting started by updating the appsettings.json.
  2. Create new strategy called NovelBinStrategy in the Benny-Scraper.BusinessLogic project, in the "Scrapers\Strategy" folder
    a. Ensure a NovelBinInitializer class is created that inherits from NovelDataInitializer.
    b. The attributesToFetch should be similar novelfull, however, the options should be determined by what is necessary to create the scraper.
  3. Add site URL along with the target strategy to HttpNovelScraper.cs AddSupportForWebSite() method.
  4. Run the application and verify that novels can be retrieved without any issues. Download an epub reader in order to validate the files open successfully.

This task is intended to be done by someone other than me to see how hard it is for others to add a new site.

@feahnthor feahnthor added the enhancement New feature or request label Aug 4, 2024
@feahnthor feahnthor self-assigned this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant