Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Need Build Instructions + Better Build Method #3040

Open
3 tasks done
dabockster opened this issue Dec 1, 2024 · 4 comments
Open
3 tasks done

[IMPROVEMENT] Need Build Instructions + Better Build Method #3040

dabockster opened this issue Dec 1, 2024 · 4 comments
Assignees
Labels
enhancement An improvement to WingetUI ready-to-go
Milestone

Comments

@dabockster
Copy link

Please confirm these before moving forward.

  • I have searched for my feature proposal and have not found a work-in-progress/duplicate/resolved/discarded issue.
  • This improvement refers to an existing feature. If you want to suggest a new feature, please use this template.
  • This improvement is not a bug. If you want to report a bug, please use this template.

Describe the improvement

There's build_release.bat in the main dir of the repo, but there's no instructions on anything beyond that. There's no information on prerequisite libraries required, no manual compilation steps, nothing. Just a batch file that executes a ton of nested Python code. Having an actual build method in like Clang or something would be way better.

Describe how this improvement could help users

The current build method executes a bunch of nested Python code. There's no way to tell what that code is doing at a glance. Having a standard build method with detailed instructions ensures that the build can be reproduced, is secure, and can be contributed to in the future (you know, because open source).

@dabockster dabockster added the enhancement An improvement to WingetUI label Dec 1, 2024
@marticliment
Copy link
Owner

There's build_release.bat in the main dir of the repo, but there's no instructions on anything beyond that. There's no information on prerequisite libraries required, no manual compilation steps, nothing. Just a batch file that executes a ton of nested Python code. Having an actual build method in like Clang or something would be way better.

This is used to build the final build, with the installed.
For test builds, visual studio or jetbrains rider should be plug and play. Just open the solution and the editor should figure everything out, since UniGetUI is built with .NET projects

@marticliment
Copy link
Owner

However, I agree this needs clarification

@marticliment marticliment modified the milestones: Bugs, Features Dec 1, 2024
@mrixner
Copy link
Contributor

mrixner commented Dec 1, 2024

There's an instructions page on your website, it just requires a lot of digging to find (and appears to be for old WingetUI, that ran on Python).

@marticliment
Copy link
Owner

yes, documentation on my web page is quite outdated, I have to work on it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to WingetUI ready-to-go
Projects
None yet
Development

No branches or pull requests

3 participants