Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about novnc compile #1

Open
linlin4426 opened this issue Jun 28, 2022 · 4 comments
Open

about novnc compile #1

linlin4426 opened this issue Jun 28, 2022 · 4 comments

Comments

@linlin4426
Copy link

Hi martin, did you compile you novnc h264 project? I build it with cmd "npm install & npm run build", but many errors occurred.

  1. webpack.config.js seems not contain ts-loader.
  2. ui.ts still contains many js file, which is had been renamed to *.ts

My usage may different from yours,I use TC35874X cart to convert HDMI to CSI, then captured YUV frame. By hardware encoding,it change from YUV frame to H264 frame, I had modifyed my vnc server depend on libvncserver library, so I want novnc client to test whether my vnc server working properly.

Thanks ~

@martin19
Copy link
Owner

Ok, seems I forgot to include ts-loader. I was working with webstorm watcher which compiles in place and didn't notice because it compiled ts to js in the background. I will have a look at this but might take a bit of time. If you know what to do I'd be happy to accept a pull request.

Did you use my libvncserver fork for your server?

@linlin4426
Copy link
Author

I forked your libvncserver, but not use it, becuse my board is not raspberrypi. It's rock3a board, which is much cheapper than raspberrypi, and many pin defined same as raspberrypi . I change libvncserver follow this vnc h264 protocol specification: https://github.com/mdevaev/rfbproto/blob/76ed1d6e8ef20d1a586e8fefa56868243929e0b7/rfbproto.rst#pi-kvm-h-264-encoding, and tested TigerVNC client https://github.com/TigerVNC/tigervnc , it works good.

One day i see you novnc branch, it looks like support vnc h264, so i want to test it. Follow your vnc h264 protocol,maybe i need to change my server, or change your client, but change your client is very difficulty,becuse i’m not know well about js.

@martin19
Copy link
Owner

This h264 branch was created as proof of concept that it works and as testbed for remote desktop on raspberry pi. Seems there is a rbf spec for h264 now (TigerVNC/tigervnc#1187) and things are moving forward a bit. I was a bit disappointed then with performance of vnc that is why this experiment was made. I do not seek to submit this fork back because it would require a lot of work and they dont seem to be moving to typescript. Also there are probably licensing isseues with the wasm module. I think you could change the implementation to follow the "official" rbf spec without too much effort if you want.

@linlin4426
Copy link
Author

Ok. Thank you for your advice, i will have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants