Japanese public holiday issue for 2025

[GuySturgess]

The list of Japanese public holidays (using both JapanPublicHoliday().PublicHolidays(2025) and JapanPublicHoliday().IsPublicHoliday() does not include the observed date for Greenery Day 2025, which falls on a Sunday (4th May 2025) and should be observed next year on 6th May 2025. It appears to have been “Mondayised” to the 5th May 2025, but this is Children’s Day and already a public holiday. Monday 5th May 2025 appears twice in this list.

[GuySturgess]

I have a fix to this if you can please grant me access o push a new code branch for review

[martinjw]

I have a fix to this if you can please grant me access o push a new code branch for review

Just fork, fix, and create a pull request - thanks!

[GuySturgess]

Hi, I am trying to push but it I get Failed to push to the remote repository. See the Output window for more details. Pushing JapanHolidays Remote: Permission to martinjw/Holiday.git denied to GuySturgess. Error encountered while pushing to the remote repository: Git failed with a fatal error. Git failed with a fatal error. unable to access 'https://github.com/martinjw/Holiday/': The requested URL returned error: 403 Regards, Guy Sturgess Software Engineering Manager M 07936 931875 Drax Power Station, Selby, North Yorkshire, YO8 8Ph United Kingdom ***@***.******@***.***> [https://www.drax.com/wp-content/uploads/2019/09/emailsignature2-draxnew-hydro.png]<https://www.drax.com/> ***@***.*** From: martinjw ***@***.***> Sent: 29 November 2024 11:08 To: martinjw/Holiday ***@***.***> Cc: Guy Sturgess ***@***.***>; Author ***@***.***> Subject: Re: [martinjw/Holiday] Japanese public holiday issue for 2025 (Issue #141) WARNING: This email originated outside of Drax Group. DO NOT CLICK links or attachments unless you recognise the sender and know the content is safe. If in doubt, click 'Report Message' at the top of your inbox and select 'Phishing' I have a fix to this if you can please grant me access o push a new code branch for review Just fork, fix, and create a pull request - thanks! - Reply to this email directly, view it on GitHub<#141 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNKGJML4FJMUNI3K577J7KD2DBDH3AVCNFSM6AAAAABSWXHEHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBXGU4DQNJUGM>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

…

________________________________ Drax Power Limited Registered in England and Wales, Number 4883589. Registered Office: Drax Power Station, Selby, North Yorkshire YO8 8PH CONFIDENTIALITY NOTICE The contents of this email, and any files transmitted with it, are confidential to the ordinary user of the email address to which it was addressed and may also be privileged. If you are not the addressee of this email you may not copy, forward, disclose or otherwise use it or any part of it in any form whatsoever. If you are not the intended recipient, or have received this email in error please email the sender immediately by replying to this message, and delete the material from any computer. This message and its contents are attributed to the sender and may not necessarily reflect the view of Drax Power Limited, its parent, subsidiaries or associates.

[martinjw]

Fork into your own github account

Then you can create a pull request from your forked branch to this one.

Github docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork