Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holiday name information to Holiday object #31

Open
bmasephol opened this issue Aug 23, 2018 · 1 comment
Open

Add holiday name information to Holiday object #31

bmasephol opened this issue Aug 23, 2018 · 1 comment

Comments

@bmasephol
Copy link

I'm using the new USAPublicHoliday().GetHolidaysInDateRange(startDate, endDate); function to get the holidays based on our time frame, which isn't 1/1/xxxx - 12/31/xxxx, its more like 2/1 - 1/31.

It requires multiple calls to get the holiday names using new USAPublicHoliday().PublicHolidayNames(year); because it has to run for two years and then do some filtering based on dates.

It would be nice if the name of the holiday was just included on the object returned from the GetHolidaysInDateRange() call.

Great library and project!

@Hrothval
Copy link
Contributor

In version 2.9, I added the name in the Holiday class. I will adjust the USAPublicHoliday class for use in my next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants