Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 19 in v2 #81

Open
Omikorin opened this issue Jan 1, 2025 · 2 comments
Open

Support for React 19 in v2 #81

Omikorin opened this issue Jan 1, 2025 · 2 comments

Comments

@Omikorin
Copy link

Omikorin commented Jan 1, 2025

Hi, is it possible to add support for React 19 with pages router?
I mean the peerDependencies fails on every install without using the --force.

I tested this package with React 19 on Next 15 pages router and everything works great. There are some tests issues to resolve in the package before it can be built. Do you have time to work on this? Probably, this will need a bump of some deps to remove warnings and potential future breaks.

Edit: Tests are not working correctly on the 2.x.x branch, so it doesn't matter to fix them but they started passing (all of them) after updating to a higher version.

image

@martinkr
Copy link
Owner

martinkr commented Jan 6, 2025

Hi @Omikorin,

Thank you for your contribution.

Would you be open to submitting a PR addressing your findings? That would be amazingly helpful!

Thank you in advance!

@Omikorin
Copy link
Author

Omikorin commented Jan 6, 2025

I wish to do it @martinkr but I am unable to build 2.x.x branch neither main.

I fixed the package.json file (duplicated and wrong next dependencies) and missing hash property type in the LinkWithLocale but without success. Whenever I am close to building it, I am blocked by this tslib error:

image

edit: nevermind, I put resolutions for [email protected] and it built successfully on the main branch. Maybe it's possible to fix this build process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants