Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabs to search results #288

Open
ghost opened this issue May 18, 2017 · 5 comments
Open

Add tabs to search results #288

ghost opened this issue May 18, 2017 · 5 comments

Comments

@ghost
Copy link

ghost commented May 18, 2017

No description provided.

@marverenic
Copy link
Collaborator

marverenic commented May 19, 2017

I'm pretty partial to the mixed results page that's currently there. I can see where it would be convenient if you only care about a specific type of result, but I like being able to see results from all types when you've got a more specific query. The current search page also lets you just use the keyboard to find what you're looking for, without having to switch between tabs.

Maybe a "top results" section would be more helpful? Just something that would highlight a couple of results that best match what you're searching for (regardless of type).

@ghost
Copy link
Author

ghost commented May 19, 2017

First of all, try changing the results order to Artists, Albums, Songs. I can't really tell about the top results thing - I guess it depends on how well it'd work.

@ghost
Copy link
Author

ghost commented May 19, 2017

Instead of doing that, maybe just display only direct results? So if a user searches for an artist, don't show all their songs and albums. If an album - don't show the songs it contains.

@marverenic
Copy link
Collaborator

Right now searching includes a song if either its song name, artist name, or album name contains the search query (and includes an album if either its album name or artist name contain the query). Just to confirm, you're saying to change this so that songs and albums are only included in the results if their name contains the query, right?

@ghost
Copy link
Author

ghost commented May 20, 2017

Yes, instead of creating a seperate section with best results, I'd narrow all results shown to the best, accurate ones. This way if you only reorder elements to Artists, Albums, Songs it's much quicker for users to find what they want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants