New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support get_XXXX_by_name in simulator or not? #36

Open

masanorihirano opened this issue Nov 9, 2022 · 0 comments

Labels

need discussion

Owner

masanorihirano commented Nov 9, 2022

In the original plhamJ package, some getXXXXByName methods are implemented to simulator.

https://github.com/plham/plhamJ/blob/7702c3ac6372766fa3acdfc2870384ae941ff9cc/core/src/main/java/plham/core/main/Simulator.java#L216-L234

In pams, I think simulator.name2market can be a replacement.

pams/pams/simulator.py

Line 59 in f87ccf8

self.name2market: Dict[str, Market] = {}

But, if those methods are necessary for the certain purpose, we should consider the implementation again.
If not, we should drop the following ToDo:

pams/pams/simulator.py

Line 298 in f87ccf8

# ToDo get_xxx_by_name

masanorihirano added the need discussion label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment