From fd67de6a2845dae536ea4800bae888f10ee74bc1 Mon Sep 17 00:00:00 2001 From: Dmytro <94nj111@gmail.com> Date: Sun, 8 Dec 2024 15:43:32 +0200 Subject: [PATCH] api-views solution --- .flake8 | 1 + .gitignore | 2 +- ...emahall_genre_movie_actors_movie_genres.py | 75 +++++++++++ cinema/models.py | 26 ++++ cinema/serializers.py | 35 ++--- cinema/urls.py | 42 +++++- cinema/views.py | 122 +++++++++++++----- 7 files changed, 253 insertions(+), 50 deletions(-) create mode 100644 cinema/migrations/0002_actor_cinemahall_genre_movie_actors_movie_genres.py diff --git a/.flake8 b/.flake8 index cabebb864..b4c0e171a 100644 --- a/.flake8 +++ b/.flake8 @@ -6,5 +6,6 @@ max-complexity = 18 select = B,C,E,F,W,T4,B9,Q0,N8,VNE exclude = **migrations + .venv venv tests \ No newline at end of file diff --git a/.gitignore b/.gitignore index 9c18d6ac5..ad6d9166c 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,7 @@ *.iml .env .DS_Store -venv/ +.venv/ .pytest_cache/ **__pycache__/ *.pyc diff --git a/cinema/migrations/0002_actor_cinemahall_genre_movie_actors_movie_genres.py b/cinema/migrations/0002_actor_cinemahall_genre_movie_actors_movie_genres.py new file mode 100644 index 000000000..9dd7459be --- /dev/null +++ b/cinema/migrations/0002_actor_cinemahall_genre_movie_actors_movie_genres.py @@ -0,0 +1,75 @@ +# Generated by Django 4.1 on 2024-12-08 12:28 + +from django.db import migrations, models + + +class Migration(migrations.Migration): + + dependencies = [ + ("cinema", "0001_initial"), + ] + + operations = [ + migrations.CreateModel( + name="Actor", + fields=[ + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ("first_name", models.CharField(max_length=255)), + ("last_name", models.CharField(max_length=255)), + ], + ), + migrations.CreateModel( + name="CinemaHall", + fields=[ + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ("name", models.CharField(max_length=255)), + ("rows", models.IntegerField()), + ("seats_in_row", models.IntegerField()), + ], + ), + migrations.CreateModel( + name="Genre", + fields=[ + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ("name", models.CharField(max_length=255, unique=True)), + ], + ), + migrations.AddField( + model_name="movie", + name="actors", + field=models.ManyToManyField( + related_name="movies", to="cinema.actor" + ), + ), + migrations.AddField( + model_name="movie", + name="genres", + field=models.ManyToManyField( + related_name="movies", to="cinema.genre" + ), + ), + ] diff --git a/cinema/models.py b/cinema/models.py index cc477513f..24956ebc0 100644 --- a/cinema/models.py +++ b/cinema/models.py @@ -1,9 +1,35 @@ from django.db import models +class Actor(models.Model): + first_name = models.CharField(max_length=255) + last_name = models.CharField(max_length=255) + + def __str__(self): + return f"{self.first_name} {self.last_name}" + + +class Genre(models.Model): + name = models.CharField(max_length=255, unique=True) + + def __str__(self): + return self.name + + +class CinemaHall(models.Model): + name = models.CharField(max_length=255) + rows = models.IntegerField() + seats_in_row = models.IntegerField() + + def __str__(self): + return self.name + + class Movie(models.Model): title = models.CharField(max_length=255) description = models.TextField() + actors = models.ManyToManyField(Actor, related_name="movies") + genres = models.ManyToManyField(Genre, related_name="movies") duration = models.IntegerField() def __str__(self): diff --git a/cinema/serializers.py b/cinema/serializers.py index 050db5771..111c58918 100644 --- a/cinema/serializers.py +++ b/cinema/serializers.py @@ -1,24 +1,27 @@ from rest_framework import serializers -from cinema.models import Movie +from cinema.models import Movie, Actor, Genre, CinemaHall -class MovieSerializer(serializers.Serializer): - id = serializers.IntegerField(read_only=True) - title = serializers.CharField(max_length=255) - description = serializers.CharField() - duration = serializers.IntegerField() +class MovieSerializer(serializers.ModelSerializer): + class Meta: + model = Movie + fields = ["id", "title", "description", "duration"] - def create(self, validated_data): - return Movie.objects.create(**validated_data) - def update(self, instance, validated_data): - instance.title = validated_data.get("title", instance.title) - instance.description = validated_data.get( - "description", instance.description - ) - instance.duration = validated_data.get("duration", instance.duration) +class ActorSerializer(serializers.ModelSerializer): + class Meta: + model = Actor + fields = ["id", "first_name", "last_name"] - instance.save() - return instance +class GenreSerializer(serializers.ModelSerializer): + class Meta: + model = Genre + fields = ["id", "name"] + + +class CinemaHallSerializer(serializers.ModelSerializer): + class Meta: + model = CinemaHall + fields = ["id", "name", "rows", "seats_in_row"] diff --git a/cinema/urls.py b/cinema/urls.py index 1ae7d5cb0..084dfaefa 100644 --- a/cinema/urls.py +++ b/cinema/urls.py @@ -1,10 +1,44 @@ -from django.urls import path +from django.urls import path, include +from rest_framework import routers -from cinema.views import movie_list, movie_detail +from cinema.views import ( + MovieViewSet, + GenreList, + GenreDetail, + ActorList, + ActorDetail, + CinemaHallViewSet, +) + + +movie_router = routers.DefaultRouter() +movie_router.register("movies", MovieViewSet) + +cinema_hall_list = CinemaHallViewSet.as_view( + actions={"get": "list", "post": "create"} +) + +cinema_hall_detail = CinemaHallViewSet.as_view( + actions={ + "get": "retrieve", + "put": "update", + "patch": "partial_update", + "delete": "destroy", + } +) urlpatterns = [ - path("movies/", movie_list, name="movie-list"), - path("movies//", movie_detail, name="movie-detail"), + path("", include(movie_router.urls)), + path("genres/", GenreList.as_view(), name="genre_list"), + path("genres//", GenreDetail.as_view(), name="genre_detail"), + path("actors/", ActorList.as_view(), name="actor_list"), + path("actors//", ActorDetail.as_view(), name="actor_detail"), + path("cinema_halls/", cinema_hall_list, name="cinema_hall_list"), + path( + "cinema_halls//", + cinema_hall_detail, + name="cinema_hall_detail", + ), ] app_name = "cinema" diff --git a/cinema/views.py b/cinema/views.py index 78ba8a79c..d59bf3a69 100644 --- a/cinema/views.py +++ b/cinema/views.py @@ -1,45 +1,109 @@ -from rest_framework.decorators import api_view from rest_framework.response import Response -from rest_framework import status - +from rest_framework import status, viewsets, generics, views, mixins from django.shortcuts import get_object_or_404 -from cinema.models import Movie -from cinema.serializers import MovieSerializer +from cinema.models import Movie, Actor, Genre, CinemaHall +from cinema.serializers import ( + MovieSerializer, + ActorSerializer, + GenreSerializer, + CinemaHallSerializer, +) + +class GenreList(views.APIView): -@api_view(["GET", "POST"]) -def movie_list(request): - if request.method == "GET": - movies = Movie.objects.all() - serializer = MovieSerializer(movies, many=True) + def get(self, request): + genres = Genre.objects.all() + serializer = GenreSerializer(genres, many=True) return Response(serializer.data, status=status.HTTP_200_OK) - if request.method == "POST": - serializer = MovieSerializer(data=request.data) - if serializer.is_valid(): - serializer.save() - return Response(serializer.data, status=status.HTTP_201_CREATED) + def post(self, request): + serializer = GenreSerializer(data=request.data) + serializer.is_valid(raise_exception=True) + serializer.save() + return Response(serializer.data, status=status.HTTP_201_CREATED) - return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) +class GenreDetail(views.APIView): -@api_view(["GET", "PUT", "DELETE"]) -def movie_detail(request, pk): - movie = get_object_or_404(Movie, pk=pk) + def get_object(self, pk: int): + return get_object_or_404(Genre, pk=pk) - if request.method == "GET": - serializer = MovieSerializer(movie) + def get(self, request, pk): + serializer = GenreSerializer(self.get_object(pk=pk)) return Response(serializer.data, status=status.HTTP_200_OK) - if request.method == "PUT": - serializer = MovieSerializer(movie, data=request.data) - if serializer.is_valid(): - serializer.save() - return Response(serializer.data, status=status.HTTP_200_OK) + def put(self, request, pk): + serializer = GenreSerializer(self.get_object(pk=pk), data=request.data) + serializer.is_valid(raise_exception=True) + serializer.save() + return Response(serializer.data, status=status.HTTP_200_OK) - return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) + def patch(self, request, pk): + serializer = GenreSerializer( + self.get_object(pk=pk), + data=request.data, + partial=True + ) + serializer.is_valid(raise_exception=True,) + serializer.save() + return Response(serializer.data, status=status.HTTP_200_OK) - if request.method == "DELETE": - movie.delete() + def delete(self, request, pk): + self.get_object(pk=pk).delete() return Response(status=status.HTTP_204_NO_CONTENT) + + +class ActorList( + generics.GenericAPIView, + mixins.ListModelMixin, + mixins.CreateModelMixin +): + queryset = Actor.objects.all() + serializer_class = ActorSerializer + + def get(self, request, *args, **kwargs): + return self.list(request, *args, **kwargs) + + def post(self, request, *args, **kwargs): + return self.create(request, *args, **kwargs) + + +class ActorDetail( + generics.GenericAPIView, + mixins.RetrieveModelMixin, + mixins.UpdateModelMixin, + mixins.DestroyModelMixin, +): + queryset = Actor.objects.all() + serializer_class = ActorSerializer + + def get(self, request, *args, **kwargs): + return self.retrieve(request, *args, **kwargs) + + def put(self, request, *args, **kwargs): + return self.update(request, *args, **kwargs) + + def patch(self, request, *args, **kwargs): + return self.partial_update(request, *args, **kwargs) + + def delete(self, request, *args, **kwargs): + return self.destroy(request, *args, **kwargs) + + +class CinemaHallViewSet( + viewsets.GenericViewSet, + mixins.ListModelMixin, + mixins.CreateModelMixin, + mixins.RetrieveModelMixin, + mixins.UpdateModelMixin, + mixins.DestroyModelMixin, +): + queryset = CinemaHall.objects.all() + serializer_class = CinemaHallSerializer + + +class MovieViewSet(viewsets.ModelViewSet): + queryset = Movie.objects.all() + serializer_class = MovieSerializer