Make the status icon more a11y friendly #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raveit65
reviewed
Mar 11, 2022
src/gpm-tray-icon.c
Outdated
| @@ -92,6 +92,7 @@ gpm_tray_icon_set_tooltip (GpmTrayIcon *icon, const gchar *tooltip) | |||
| g_return_val_if_fail (tooltip != NULL, FALSE); | |||
|
|
|||
| gtk_status_icon_set_tooltip_text (icon->priv->status_icon, tooltip); | |||
| gtk_status_icon_set_title (icon->priv->status_icon, tooltip); | |||
There was a problem hiding this comment.
Please respect our code-style. Indent is ugly.
|
|
I don't see any title in the tooltip with PR. It simply looks like before. |
|
Try using Orca for your test, this PR introduces no visual changes. |
|
Sorry, i am not familiar with orca. |
|
gtk_status_icon_set_title has been deprecated since version 3.14 and should not be used in newly-written code. |
|
That's true, however the power manager uses the status icon APIs, so this PR adds accessibility without rewriting the entire status icon handling code which might be somewhere on the roadmap or it might not, I don't know and i have no idea how Mate handles the new notifications either. |
|
Note that ALL status icon code is deprecated in GTK as it depends on GtkPlug/GtkSocket which in turn depend on Xembed, which in turn depends on Xorg and is not available in Wayland.
Therefore, there is no reason given that one is working on a status icon to worry about any particular piece of code being deprecated. We just need to make it work, and GNOME does not remove deprecated symbols within the same major version (Such as GTK 3.anything). As long as we use Gtk3 and do not transition to Gtk4 all of that is still supposed to work. To bitrot this and break it would probably require some big change in cairo or xorg itself. and so far GTK 2 still works and has not become broken.
On 4/25/2022 at 9:32 AM, "Lukáš Tyrychtr" ***@***.***> wrote:
That's true, however the power manager uses the status icon APIs,
so this PR adds accessibility without rewriting the entire status
icon handling code which might be somewhere on the roadmap or it
might not, I don't know and i have no idea how Mate handles the
new notifications either.
--
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-power-
manager/pull/375#issuecomment-1108579885
You are receiving this because you are subscribed to this thread.
Message ID: <mate-desktop/mate-power-
***@***.***>
|
|
Any updates on this? |
|
I'd like to know myself... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows assistive technologies to see the tooltip of the status icon, which makes it much more useful.