Brightness fixes #403
Open
Brightness fixes #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always set brightness. If running on battery and battery dimming is disabled, the AC value should be used instead of doing nothing. This partly reverts commit 3fb36a3dce47e86d3cf8f855ba56765aa4372ac6a - I may stand corrected, but I don't see the intention of the "GPM_SETTINGS_KBD_BACKLIGHT_BATT_REDUCE" switch is to completely disable control of keyboard backlight. It seems even more random only doing this when running on battery. Completely disabling kb backlight control should be offloaded to a separate switch like in LCD backlight control (see GPM_SETTINGS_BACKLIGHT_ENABLE).
Toggling backlight brightness would always write 0 before. Now saved_brightness is initilized to 0 and only gets changed when brightness toggle is switched off.
Also save brightness config changes when running on battery. To do that, calculate backlight dim factor and ac brightness factor from master percentage value so that ac factor is only changed if brightness is further increased when battery dim factor is already zero. This behaviour seems less random to me than only saving changes when running on AC.
Add power manager switch to completely disable keyboard backlight brightness control by GPM. This goes together with reverting the patch that allows to disable keyboard backlight control via kbd-backlight-battery-reduce.
|
I cannot test this myself, as I don't have anything with a backlit keyboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a simple bug in KBD backlight toggle key handling and add some functionality to make KBD and LCD backlight control behave a bit more sane.
Fixes #187 as LCD brightness changes by function keys in battery mode are saved to config now.
It does not fix the problems with keyboard backlight described there, as I found this is a completely different issue. For example on my lenovo laptop, changing keyboard backlight by Fn+Space does not generate a scancode, thus GPM can't keep track of changes made to keyboard backlight. One might come up with some trickery to take such untracked changes in hardware into account, but I found a quick fix that adds a switch to completely disable KBD brightness control in dconf more useful for now.