Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tone should work with css-variables #8167

Open
worthy7 opened this issue Dec 14, 2023 · 0 comments
Open

Tone should work with css-variables #8167

worthy7 opened this issue Dec 14, 2023 · 0 comments

Comments

@worthy7
Copy link

worthy7 commented Dec 14, 2023

https://github.com/material-components/material-components-web/blame/8656bf0e032270f97d8673d33aaab4760befb5bc/packages/mdc-theme/_theme-color.scss#L66

Is this really neccessary? Why can it not work with css variables too? What happens if var(--my-primary-color) is passed in instead?

Can this code detect if it is a var and just resolve it and continue?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@worthy7