Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test page throws 'ui is not defined' #215

Open
guncha opened this issue Feb 18, 2015 · 3 comments
Open

Test page throws 'ui is not defined' #215

guncha opened this issue Feb 18, 2015 · 3 comments
Labels

Comments

@guncha
Copy link

guncha commented Feb 18, 2015

Just tried to create a very simple test case and it's not working for me in the latest Chrome. The benchmark-42.js file isn't even fetched from what I can see in the network inspector.

http://jsperf.com/extract-hostname-angular-element-vs-regex-v2

@jdalton jdalton added the bug label Feb 18, 2015
@mathiasbynens
Copy link
Owner

http://jsperf.com/extract-hostname-angular-element-vs-regex-v2

That seems like an issue with the test itself rather than with jsPerf. It’s using <script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.3.13/angular.min.js" />. This does not actually close the <script> element in HTML, so the rest of the output gets eaten.

@jdalton
Copy link
Collaborator

jdalton commented Feb 18, 2015

I've noticed this too in general (so related real issue) 😸
For me if I press enter on the Chrome location bar it will load again without the error.

@mathiasbynens mathiasbynens reopened this Feb 20, 2015
@kuba-orlik
Copy link

I get the same error in this test case, even though it closes <script> tags correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants