Skip to content
This repository has been archived by the owner on Jan 20, 2025. It is now read-only.

SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS #58

Closed
notixor opened this issue Jul 18, 2024 · 7 comments
Closed

SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS #58

notixor opened this issue Jul 18, 2024 · 7 comments

Comments

@notixor
Copy link

notixor commented Jul 18, 2024

DEFAULT_MAX_SSE_CLIENTS in AsyncEventSource.h not used anywhere

@notixor notixor added the question Further information is requested label Jul 18, 2024
@mathieucarbou
Copy link
Owner

You're totally right: this fork is based on:

DEFAULT_MAX_SSE_CLIENTS was added by ESPHome guys, and looking at it, even now, they just added it but they do not use it.

I think they wanted to implement a cleanup procedure like it is done in the websocket part.

Feel free to contribute and add this feature!
Like said, since I do not have any SSE use case at hand, if there's no contributions, this part will not be improved.

@mathieucarbou mathieucarbou added enhancement help wanted Extra attention is needed and removed question Further information is requested labels Jul 18, 2024
@mathieucarbou mathieucarbou changed the title [Q]DEFAULT_MAX_SSE_CLIENTS [F] SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS Jul 18, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 18, 2024
@mathieucarbou mathieucarbou changed the title [F] SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS [Feat] SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS Aug 30, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 11, 2024
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@mathieucarbou mathieucarbou reopened this Nov 18, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 19, 2024
@mathieucarbou mathieucarbou changed the title [Feat] SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS Dec 21, 2024
@mathieucarbou mathieucarbou removed help wanted Extra attention is needed feature labels Dec 21, 2024
@mathieucarbou
Copy link
Owner

Closing - DEFAULT_MAX_SSE_CLIENTS was removed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants