Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with downcased corpus #2

Open
Redithion opened this issue Sep 1, 2015 · 2 comments
Open

Problems with downcased corpus #2

Redithion opened this issue Sep 1, 2015 · 2 comments

Comments

@Redithion
Copy link

Hi there,
I have an issue with the gem, when you give a corpus already downcased it fails because downcase! returns nil.
Here is the line: https://github.com/mathieuripert/ruby-tf-idf/blob/master/lib/ruby-tf-idf.rb#L100
Maybe you can just use "downcase" instead of "downcase!".
Regards

@Redithion Redithion changed the title Problems with downcased words Problems with downcased corpus Sep 1, 2015
@Redithion
Copy link
Author

I submitted a pull request for this issue.

@Redithion
Copy link
Author

For anyone with this issue, I forked the project and fixed that. Here is the repository: https://github.com/Redithion/ruby-tf-idf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant