Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve UI issues with new top of datatable controls #22950

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Resolve UI issues with new top of datatable controls #22950

merged 14 commits into from
Jan 23, 2025

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented Jan 20, 2025 •
edited
Loading

Description:

  1. Pass search click to underlying tag to make the whole click target work correctly to resolve an issue where clicking the icon focused the input field but the whole click target (grey on hover) didn't if clicked outside of the icon.
  2. Adjust data table padding and position when comparing vertical bars as this forces horizontal scroll which cuts off table controls.

Review

@michalkleiner michalkleiner requested a review from a team January 20, 2025 00:46
@michalkleiner michalkleiner added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Jan 20, 2025
@michalkleiner michalkleiner added this to the 5.3.0 milestone Jan 20, 2025
@michalkleiner michalkleiner changed the title Pass search click to underlying <a> tag to make the whole click target work correctly Resolve UI issues with new top of datatable controls Jan 20, 2025
@michalkleiner
Copy link
Contributor Author

The integration test failures are the google rank failures (unrelated) and there's one mobile menu UI test failing that I'd say is also unrelated.

@michalkleiner michalkleiner merged commit 0e6d346 into 5.x-dev Jan 23, 2025
23 of 26 checks passed
@michalkleiner michalkleiner deleted the dev-18857 branch January 23, 2025 08:33
valentinab25 pushed a commit to valentinab25/matomo that referenced this pull request Jan 27, 2025
@michalkleiner @valentinab25
Resolve UI issues with new top of datatable controls (matomo-org#22950)
fa986aa 
* Pass click action to underlying a tag to make the whole click target work correctly
* Adjust datatable behaviour if scroll-x is enforced for vertical bars when comparing
* Fix top controls spacing issue when widgetizing reports
* Update UI test screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caddoo caddoo caddoo approved these changes

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @caddoo