-
-
Notifications
You must be signed in to change notification settings - Fork 830
Accessibility: Add Keyboard Navigation for Messages #12328
Conversation
ef13ec5
to
7741ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI won't pass until some tests are written
You can CTRL+UP your way into collapsed events without them being expanded. This makes it look like nothing is happening when you enter the keys but it's really moving each event up in the collapsed section. Not sure if that is a showstopper. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to not work very reliably. Sometimes the focus outline doesn't show. Sometimes it takes mashing the key combo a handful of times for it to move. Sometimes it jumps skipping events.
Screen.Recording.2024-06-10.at.10.38.14.mov
I kept a consistent cadence on the button presses. Looks like maybe it gets stuck on event list summaries for the number of events they contain rather than just treating it as one tile
Fixes element-hq/element-web#25123. Extracted from #12189.
Allows to use the keyboard to navigate to messages:
Checklist
Signed-off-by:
Alex Kirk <[email protected]>
Here's what your changelog entry will look like:
✨ Features