Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Accessibility: Add Keyboard Navigation for Messages #12328

Closed
wants to merge 16 commits into from

Conversation

akirk
Copy link
Contributor

@akirk akirk commented Mar 8, 2024

Fixes element-hq/element-web#25123. Extracted from #12189.

Allows to use the keyboard to navigate to messages:

message-navigation

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Alex Kirk <[email protected]>


Here's what your changelog entry will look like:

✨ Features

  • Accessibility: Add Keyboard Navigation for Messages (#12189). Contributed by @akirk.

@akirk akirk requested a review from a team as a code owner March 8, 2024 11:03
@akirk akirk requested review from t3chguy and MidhunSureshR March 8, 2024 11:03
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Mar 8, 2024
@akirk akirk changed the title Accessibility: Add message keyboard navigation Accessibility: Add Keyboard Navigation for Messages Mar 8, 2024
@t3chguy t3chguy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 8, 2024
@akirk akirk mentioned this pull request Mar 8, 2024
3 tasks
@akirk akirk force-pushed the add-message-keyboard-nav branch from ef13ec5 to 7741ab6 Compare March 8, 2024 14:07
@akirk akirk marked this pull request as draft March 8, 2024 14:07
@akirk akirk marked this pull request as ready for review March 8, 2024 14:07
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI won't pass until some tests are written

src/components/views/rooms/SendMessageComposer.tsx Outdated Show resolved Hide resolved
src/components/structures/MessagePanel.tsx Show resolved Hide resolved
@MidhunSureshR
Copy link
Contributor

MidhunSureshR commented May 22, 2024

You can CTRL+UP your way into collapsed events without them being expanded. This makes it look like nothing is happening when you enter the keys but it's really moving each event up in the collapsed section. Not sure if that is a showstopper.

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to not work very reliably. Sometimes the focus outline doesn't show. Sometimes it takes mashing the key combo a handful of times for it to move. Sometimes it jumps skipping events.

Screen.Recording.2024-06-10.at.10.38.14.mov

I kept a consistent cadence on the button presses. Looks like maybe it gets stuck on event list summaries for the number of events they contain rather than just treating it as one tile

Screen.Recording.2024-06-10.at.10.39.20.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessible navigation on messages in a room
4 participants