Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does "part of a space" mean in terms of the space hierarchy? #1309

Open
MadLittleMods opened this issue Oct 28, 2022 · 2 comments
Open
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Oct 28, 2022

Link to problem area:

Rooms can additionally claim to be part of a space by populating their own state with a parent event.

-- https://spec.matrix.org/v1.4/client-server-api/#mspaceparent-relationships

Relevant MSC1772

Issue: What is wrong? How can we improve?

Confusion as experienced #synapse-dev (most of this is cribbed from @reivilibre's comments),

It's not clear what "part of a space" means here.

  • Are rooms, with m.space.parent → some space, meant to show up in the space hierarchy for that space?
  • Or is that only for rooms which are a m.space.child of the space?

Element (the client) will display the room in the active space if it has a parent of that active space, but not in the hierarchy.

rstrst room with m.space.parent shows up when viewing the space rstrst room with m.space.parent does not show when viewing it in the space hierarchy
@MadLittleMods MadLittleMods added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label Oct 28, 2022
@deepbluev7
Copy link
Contributor

deepbluev7 commented Oct 28, 2022

In my opinion it should show up in the hierarchy, but only if the user is a member of that room already. Otherwise you leak hidden rooms. (Also of course the powerlevel check has to pass.)

@clokep
Copy link
Member

clokep commented Oct 28, 2022

Are rooms, with m.space.parent → some space, meant to show up in the space hierarchy for that space?

Do you mean "in the response to the /hierarchy request"? Then the answer is no, they are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Development

No branches or pull requests

3 participants