-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI: Timestamps should be int64 #749
Comments
This is another case where the canonical JSON spec disagrees with what we're trying to do with it. https://spec.matrix.org/v1.2/appendices/#signing-json related: #1085 |
int64 stores values corresponding to the range specified in the Canonical JSON text, doesn't it? |
The spec holds 2^53, not 2^64 |
I should learn arithmetics, it seems. That being said, |
The following (not conclusively exhaustive) list has timestamps of
integer
type with no specifiedformat
. Whenformat
is not specified, Swagger falls back to JSON Schema for type definitions. JSON Schema conveniently says that integers should be distinguished from floating-point numbers, and stops at that.The conclusion from the above is that we should be clear which
integer
is used in each particular place. This issue is about timestamps, which should always beint64
. The question is - do we need an MSC here or would a clarification be enough.ts
asnumber
, not following JSON Schema's spirit; but there's no way to specify precision in JSON Schema so perhaps it's safer to leave it as is).The text was updated successfully, but these errors were encountered: