Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json instead of json5 for syntax highlighting #2017

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Nov 28, 2024

Chroma, the library used for syntax highlighting in Hugo, does not support JSON5 so those code blocks were not highlighted. However it supports comments in JSON so they are highlighted correctly in the rendered spec.

Pull Request Checklist

Preview: https://pr2017--matrix-spec-previews.netlify.app

Chroma, the library used for syntax highlighting in Hugo, does not support JSON5 so those code blocks were not highlighted.
However it supports comments in JSON so they are highlighted correctly in the rendered spec.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner November 28, 2024 14:32
Signed-off-by: Kévin Commaille <[email protected]>
@KitsuneRal KitsuneRal merged commit f64eec5 into matrix-org:main Nov 28, 2024
12 checks passed
@zecakeh zecakeh deleted the no-json5 branch November 28, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants