New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 3: Map check in client not needed #61

Open

razvan-tache opened this issue Aug 4, 2018 · 0 comments

razvan-tache commented Aug 4, 2018

Hi,

In chapter 3, client.go there is a test for the avatar url in the user data map:
https://github.com/matryer/goblueprints/blob/master/chapter3/chat/client.go#L35

This should never fail, as it checks if the avatar_url entry is in the map, and it should always be, even if it's nil as per: https://github.com/matryer/goblueprints/blob/master/chapter3/chat/auth.go#L106

Also, if it's a nil, then a panic will happen.

Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment