Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch all players in league #32

Open
brianzhou13 opened this issue Sep 25, 2022 · 3 comments
Open

Fetch all players in league #32

brianzhou13 opened this issue Sep 25, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@brianzhou13
Copy link

brianzhou13 commented Sep 25, 2022 •
edited
Loading

Would it be possible to pull the available players on the waiver wire for a league?

Thanks!
@mattdodge
Copy link
Owner

This is a good request, thanks! It should in theory be possible with the player resource request in the Yahoo API. It will be a bit of a time consuming request (most leagues have hundreds if not thousands of players to fetch) but it should be doable

@mattdodge mattdodge added the enhancement New feature or request label Oct 31, 2022
@mattdodge mattdodge changed the title Feature request Fetch all players in league Oct 31, 2022
xaph added a commit to xaph/yahoofantasy that referenced this issue Dec 28, 2023
@xaph
implements mattdodge#32. adds league.players() method to get all play…
9cdcdd0 
…ers in a league. players api is paginated so solution loops over all pages
@xaph xaph mentioned this issue Dec 28, 2023
Merged
@xaph
Copy link
Contributor

xaph commented Dec 28, 2023

@mattdodge I have created a pull request with a couple of comments. Can you check it?

@mattdodge
Copy link
Owner

Awesome, thanks @xaph! Took a quick glance and it looks great, will do a deeper review in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xaph @mattdodge @brianzhou13