Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --tags in push command #57

Open
matteosister opened this issue Aug 2, 2014 · 9 comments
Open

Add support for --tags in push command #57

matteosister opened this issue Aug 2, 2014 · 9 comments

Comments

@matteosister
Copy link
Owner

No description provided.

@John-Schlick
Copy link
Contributor

I do this like:

  $to = self::ORIGIN; // My own constant for 'origin'.
  $ref = "--tags";
  $this->repository->push($to, $ref);

and it works great. It's a bit of a hack since ref is "supposed" to be the branch to push, and this sticks --tags in it's place.

@adamlacoste
Copy link

I think it would be good to have the param as a boolean flag on the repo method, instead of resorting to the hack @John-Schlick mentions.

@John-Schlick
Copy link
Contributor

I am fully in favor of a flag to do this. If you look at the pull requests and issues with attached code, every one of them adds flags to do things.

I am merely pointing out that it's POSSIBLE to push tags today with no additional code.

@adamlacoste
Copy link

Sorry @John-Schlick, I wasn't suggesting that you were opposed to a fix. Just throwing my endorsement behind a more comprehensive fix.

@John-Schlick
Copy link
Contributor

To tell the truth, I'd code it and show the solution code here if it weren't for the fact that they don't "like" my solution code, and have yet to take any of it. Thats why, for things like this where I don't HAVE to change the codebase - I don't.

@davidromani
Copy link

Is somebody still working on this issue? I need this feature and I can provide a PR if you are agree... tell me something please.

Thanks.

@matteosister
Copy link
Owner Author

I'm not working on this library anymore. I'm not even using much PHP nowaday. So if you want privileges to push on this repo I will be happy to add you as a maintainer. Just let me know...

@davidromani
Copy link

davidromani commented Jan 9, 2017

Sorry, I can't reach this responsibility for now. But, I can make a PR if it's enough...

@matteosister
Copy link
Owner Author

of course! No problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants