Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message when compiling dependant of skipped contract #672

Open
Karrq opened this issue Oct 29, 2024 · 0 comments
Open

Misleading error message when compiling dependant of skipped contract #672

Karrq opened this issue Oct 29, 2024 · 0 comments
Labels
compiler 📟 Issues specific to compiling needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item

Comments

@Karrq
Copy link
Contributor

Karrq commented Oct 29, 2024

When you avoid a contract to compile that is too large for zksolc that is used by other contract (inherits from it) the compilation fails but the error is confusing for the user. The error will say that it could not compile the parent contract which you already excluded. We should aim to improve the error message and/or also exclude all dependant contracts from compilation.

→ Example

contract AaveV3Ethereum_LlamariskRiskProvider_20240421_Test is ProtocolV3TestBase

this contract will fail its compilation but the error would say that the compiler could not compile ProtocolV3TestBase which the user was avoiding in the first place already.

@Karrq Karrq added compiler 📟 Issues specific to compiling needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler 📟 Issues specific to compiling needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item
Projects
None yet
Development

No branches or pull requests

1 participant