Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailbox address alias is not applied to refundRecipient #16

Open
antonper opened this issue Mar 9, 2023 · 1 comment
Open

Mailbox address alias is not applied to refundRecipient #16

antonper opened this issue Mar 9, 2023 · 1 comment

Comments

@antonper
Copy link

antonper commented Mar 9, 2023

Hello,

The requestL2Transaction function applies the applyL1ToL2Alias to the msg.sender if the sender is smart contract.
However, in _requestL2Transaction the params.refundRecipient is assigned as:

 params.refundRecipient = _refundRecipient == address(0) ? msg.sender : _refundRecipient;

I think 2 things are not clear in this context and can be potential bugs:

  1. The submitted refundRecipient address needs to be already aliased address, which is not clear from the docs.
  2. The address(0) as refundRecipient will set wrong address if sender is a contract.

Please let me know if those concerns are valid.
Thank you

@ghost
Copy link

ghost commented Mar 14, 2023

sorry but if you could nudgebme in the right direction ill try to do my best.. i have tons of tinkering files on the test and all kinds of adresses. i was just getting those gears going... hope i didnt piss off too many

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@antonper and others