Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access Webex site from client side #22

Open
bbodenmiller opened this issue Jan 25, 2020 · 7 comments
Open

access Webex site from client side #22

bbodenmiller opened this issue Jan 25, 2020 · 7 comments
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/TypeScript Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@bbodenmiller
Copy link
Contributor

Many Mattermost servers are not allowed to access the outside internet by default. This plugin should support this and access Webex site from client side.

@bbodenmiller bbodenmiller changed the title access Webex site on client side access Webex site from client side Jan 25, 2020
@levb levb added the Triage label Jan 28, 2020
@cpoile
Copy link
Contributor

cpoile commented Jan 30, 2020

@bbodenmiller This turns out to be how connections to webex work currently. The plugin generates a link and posts it in a message, and when a user clicks on the link in a message they connect directly to the webex system -- there's no traffic through the Mattermost instance during/after the link click.

Please let me know if I'm misunderstanding the issue?

@cpoile cpoile removed the Triage label Jan 30, 2020
@bbodenmiller
Copy link
Contributor Author

bbodenmiller commented Jan 31, 2020 via email

@levb
Copy link
Contributor

levb commented Feb 4, 2020

@bbodenmiller ACK. Historically, we focused on server-side and/or server-centric plugins; largely to enable functionality on mobile.

However, there's nothing really, at least in theory, preventing us from creating 100%-webapp plugins (well, serving them from the server). We should consider.

@levb levb self-assigned this Feb 4, 2020
@bbodenmiller
Copy link
Contributor Author

@levb right, I've found the Mattermost move towards more sever side connections when client side would be possible problematic. In security sensitive environments server connections to outside internet are more restricted (blocked entirely in many cases) than client side connections to outside internet.

@cpoile
Copy link
Contributor

cpoile commented Feb 4, 2020

@levb We could have a back-up webex-client code on the front end. It would query the webex server for the room url given the meeting starter's preferred setting. I think it can be a HW.

@cpoile cpoile added Difficulty/2:Medium Medium ticket Tech/JavaScript Tech/TypeScript Up For Grabs Ready for help from the community. Removed when someone volunteers labels Feb 4, 2020
@levb
Copy link
Contributor

levb commented Feb 4, 2020

It is my understanding that the client was already not restricted and has no issue connecting to WebEx; the server (plugin!) must use a proxy though. Client can be configured separately anyway.

@cpoile cpoile added the Help Wanted Community help wanted label Feb 4, 2020
@cpoile
Copy link
Contributor

cpoile commented Feb 4, 2020

You're right, the client can do the connection, but the client will need to respect the meeting starter's preferred way to find their meeting room URL (roomId, username/webexId, or email). Then the client can query the Webex server to get that URL.

We need to include that info in the meeting post (as props), then the client needs to have all the webex xml request settings to make the request (can be found in the server/webex package).

@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature and removed Enhancement labels Mar 7, 2020
@levb levb removed their assignment Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/TypeScript Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

6 participants