Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure outside of the main config.json? #42

Open
shred86 opened this issue Apr 15, 2020 · 6 comments · May be fixed by #143
Open

Ability to configure outside of the main config.json? #42

shred86 opened this issue Apr 15, 2020 · 6 comments · May be fixed by #143
Labels
Difficulty/2:Medium Medium ticket Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@shred86
Copy link

shred86 commented Apr 15, 2020

Looking at trying to use WelcomeBot on a large Mattermost instance where each team needs the ability to configure their own WelcomeBot settings. Configuring 100+ WelcomeBot team messages in the main config.json is not ideal. Is there any plan to allow for separate JSON files to be used for each team that is stored outside of the main config.json? Is it even possible or will it require changes to mattermost-server?

@levb levb self-assigned this Apr 21, 2020
@levb levb added Needs Spec Needs further specification to be a good (help wanted) ticket Triage Type/Enhancement New feature or improvement of existing feature labels Apr 21, 2020
@levb levb added this to the v1.3.0 milestone Apr 21, 2020
@levb levb removed the Triage label Apr 21, 2020
@levb
Copy link
Contributor

levb commented Apr 21, 2020

Storing config "elsewhere", e.g. in the KV Store will cause complexities with invalidation. However, much like in mattermost-community/mattermost-plugin-autolink#73, we should have an Import/Export capability. @shred86 would that address your use-case?

@shred86
Copy link
Author

shred86 commented Apr 22, 2020

Thanks for the info. If I’m understanding that import/export capability, it basically lets a user update the main config.json via a shared file? I guess I’m not completely understanding how this would work.

My understanding is the WelcomeBot plugin (like all plugins) are configured inside the main config.json file for the entire Mattermost server. I guess I’m hoping there could be a feature where we can define the plugin settings outside of the main config.json. Ideally, we would be able to create a separate directory with a JSON for each team’s WelcomeBot configuration. This way the WelcomeBot could be used for large Mattermost deployments with hundreds of teams (e.g. each team could configure their own JSON, send it to a system admin and they add it to the directory with all the other WelcomeBot config JSONs). It sounds like that won’t be possible without changes to the Mattermost server though.

@terafirmanz
Copy link

Or adding the ability to manage this in the team settings by team admins or via a /command. Having to manage this via the main config file makes things difficult even more so now with per channel support.

@hanzei
Copy link
Contributor

hanzei commented May 27, 2021

The Apps framework should be used to add a modal that allows the configuration.

@hanzei hanzei unassigned levb May 27, 2021
@hanzei hanzei added Difficulty/2:Medium Medium ticket Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Needs Spec Needs further specification to be a good (help wanted) ticket labels May 27, 2021
@hanzei hanzei added Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit and removed Up For Grabs Ready for help from the community. Removed when someone volunteers labels Jun 11, 2021
@CalebMaftei CalebMaftei mentioned this issue Jun 29, 2021
@hanzei hanzei mentioned this issue Jun 30, 2021
@hanzei hanzei removed this from the v1.3.0 milestone Mar 1, 2022
@ThiefMaster
Copy link

I have a large instance with 3k teams where anyone can create a team if they want. Requiring an admin to configure this - regardless if it's via config.json or via UI - does not scale.

If team admins could use UI or a slash command to set up welcome messages in their team it'd be much better!

@theAkito
Copy link

theAkito commented Mar 5, 2023

This issue is really important. If you are having any non-plebby deployment of Mattermost, managing the Welcome Bot's configuration via the central config.json becomes a real nuisance, very swiftly.

I just added a single button in one message & that was already pain, since the offical example provided has an error.
Additionally, the config.json does only seem to be loaded once at server startup or something, because my instance cannot see the new options added, after I enabled this plugin.

Management via a huge config.json is pain. It's really important to have some Import/Export functionality or ideally just have a form in the System Console's plugin settings for the Welcome Bot. This would be the best & most idiomatic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
6 participants