Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of not being able to add a welcome message in private channel #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue of not being able to add a welcome message in private channel #132

wants to merge 1 commit into from

Conversation

ayusht2810
Copy link
Contributor

Summary

  • Fix issue of not being able to add a welcome message in private channel

Ticket Link

Fixes #72

What to test?

  • Add a welcome message in a private channel
  • Check if the new user added to the above private channel is able to view the message

Checklist

  • Completed dev testing
  • make test Ran test cases and ensured they are passing
  • make check-style Ran style check and ensured both webapp and server pass the checks

@ayusht2810 ayusht2810 requested a review from mickmister as a code owner April 18, 2024 09:46
@ayusht2810 ayusht2810 self-assigned this Apr 18, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Apr 18, 2024
@ayusht2810
Copy link
Contributor Author

@mickmister Gentle reminder to review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister Awaiting requested review from mickmister

@raghavaggarwal2308 raghavaggarwal2308 Awaiting requested review from raghavaggarwal2308

@wiggin77 wiggin77 Awaiting requested review from wiggin77

At least 1 approving review is required to merge this pull request.

Assignees

@ayusht2810 ayusht2810

Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Welcome bot will not let me add a message to private channels
1 participant
@ayusht2810