Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN] Change "Join" button on sign in page keyboard to "Go" #26590

Open
mattermod opened this issue Mar 26, 2024 · 1 comment · May be fixed by mattermost/mattermost-mobile#7923
Open

[RN] Change "Join" button on sign in page keyboard to "Go" #26590

mattermod opened this issue Mar 26, 2024 · 1 comment · May be fixed by mattermost/mattermost-mobile#7923
Assignees
@pranavkasula
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/React Native Mobile app

Comments

@mattermod
Copy link
Contributor

When logging into a server in the mobile app on iOS, after the user types in their username and password, the return/enter key on the on-screen keyboard is labelled “Join”. We should change that to “Go”.

In order to do so, use the input prop available in React Native for that: https://reactnative.dev/docs/textinput#returnkeytype

In the PR, please provide screenshots for how it looks on both platforms (Android and iOS).

Thread link: https://community.mattermost.com/core/pl/osk54k3f9bdzimpu57wo1ojr8e

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-57205
@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Mar 26, 2024
@larkox larkox added Difficulty/1:Easy Easy ticket Tech/React Native Mobile app Good First Issue Suitable for first-time contributors labels Mar 26, 2024
@pranavkasula
Copy link

Hi I am interested in solving this issue, can I get it assigned to me?

@pranavkasula pranavkasula linked a pull request Apr 26, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranavkasula pranavkasula

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/React Native Mobile app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

addressed issue 26590 pranavkasula/mattermost-mobile
4 participants
@larkox @mattermod @amyblais @pranavkasula