Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow excluding public channels from a legal hold #59

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

fmartingr
Copy link
Contributor

@fmartingr fmartingr commented Jun 5, 2024

Summary

Adds a new option to legal holds to avoid storing data from public channels

  • Adds LegalHold.ExcludePublicChannels
  • Modified signature of GetChannelIDsForUserDuring adding one parameter. (Probably better to refactor it using an Opts struct)
  • Modified the creation form to allow checking this option
  • Modified the edit form to allow checking this option (changes would only apply from the moment the change is made)
  • Better UI

Screenshots

Screenshot 2024-06-06 at 16 13 37

Closes #55

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @fmartingr. Do you mind adding some screenshots to the PR?

server/store/sqlstore/legal_hold.go Outdated Show resolved Hide resolved
@fmartingr fmartingr changed the title feat: exclude public channels feat: allow excluding public channels from a legal hold Jun 6, 2024
@fmartingr fmartingr self-assigned this Jun 6, 2024
@fmartingr fmartingr marked this pull request as ready for review June 6, 2024 14:27
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmartingr fmartingr merged commit 06410e3 into main Jun 10, 2024
4 checks passed
@fmartingr fmartingr deleted the feat/exclude-public-channels branch June 10, 2024 05:53
@fmartingr
Copy link
Contributor Author

@AayushChaudhary0001 can you add this to the QA pipeline please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option where all public channels are excluded from legal hold
3 participants