Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access control #219

Open
darias416 opened this issue Jul 14, 2023 · 7 comments
Open

Access control #219

darias416 opened this issue Jul 14, 2023 · 7 comments

Comments

@darias416
Copy link

darias416 commented Jul 14, 2023

In preparation for deploying the plugin in production, Hercules needs a way to control access to the plugin to facilitate a staged rollout.

Currently, the only existing mechanism is the "Enabled Teams" configuration. However, Hercules has only 1 Mattermost Team with several thousand users.

@mkdbns
Copy link
Collaborator

mkdbns commented Jul 17, 2023

Did SN mention a preferred way that they would like to be able to control onboarding of users?

@darias416
Copy link
Author

@mkdbns the preferred method would be to select people based on the group they belong to. However, I confirmed they don't have AD/LDAP Groups enabled. The only other ways I can think of identifying different types of users is by using the MM System Roles or MM User Roles

cc: @johndavidlugtu @jasonblais @maxwellpower @jespino

@jasonblais
Copy link
Contributor

@darias416 this may be a good topic to raise with Spiros on our morning call, given they manage the Cloud deployment & may have additional suggestions around access control.

@johndavidlugtu
Copy link

Was there additional suggestions from Spiros and team around access control?

@jasonblais
Copy link
Contributor

@johndavidlugtu no concrete solutions yet, but we'll be meeting again next Tuesday to discuss options further

@darias416
Copy link
Author

Was there additional suggestions from Spiros and team around access control?

@johndavidlugtu we discussed the possibility of leveraging Okta groups. We will need to explore further.

@manojmalik20
Copy link
Collaborator

@darias416 I think this issue can be closed now as this is done via the whitelist feature. Here's the PR - #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants