Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router instantiated on each HTTP request #363

Open
lieut-data opened this issue Oct 18, 2023 · 0 comments
Open

Router instantiated on each HTTP request #363

lieut-data opened this issue Oct 18, 2023 · 0 comments

Comments

@lieut-data
Copy link
Member

Summary

The API router is instantiated on each HTTP request:
https://github.com/mattermost/mattermost-plugin-msteams-sync/blob/17092cd65bdfc29f9d3240aaa6251d0bbc026b47/server/plugin.go#L78-L81

Let's move this setup to OnActivate and reuse the same router.

Importance: Low
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lieut-data