Fix logging default (SeldonIO#577)

matthewlowdon · May 9, 2022 · 47ae828 · 47ae828
1 parent 9153c57
commit 47ae828
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/mlserver/rest/server.py b/mlserver/rest/server.py
@@ -52,14 +52,22 @@ async def delete_custom_handlers(self, model: MLModel):
                     handlers.pop(j)
 
     async def start(self):
-        cfg = uvicorn.Config(
-            self._app,
-            host=self._settings.host,
-            port=self._settings.http_port,
-            log_config=self._settings.logging_settings,
-        )
+        cfg = self._get_config()
         self._server = _NoSignalServer(cfg)
         await self._server.serve()
 
+    def _get_config(self):
+        kwargs = {
+            "host": self._settings.host,
+            "port": self._settings.http_port,
+        }
+
+        if self._settings.logging_settings:
+            # If not None, use ours. Otherwise, let Uvicorn fall back on its
+            # own config.
+            kwargs["log_config"] = self._settings.logging_settings
+
+        return uvicorn.Config(self._app, **kwargs)
+
     async def stop(self):
         self._server.handle_exit(sig=None, frame=None)