-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to RadioLib 7.0 #106
Comments
Hi @StevenCellist, thanks a lot for your notification and the helpful hints - and of course for putting so much effort and knowledge into the LoRaWAN part of RadioLib! |
Didn't manage to update to RadioLib v7.0.0 yet. Currently, I get strange errors like |
Do you have more information on this problem? (E.g. using debug protocol flag.) There has been no change to the persistence side, except for some rearranging of the internal buffer size & structure. |
@StevenCellist Thanks for offering help and the information that no changes have been made regarding persistence handling. I enabled protocol output, erased the Flash (again) to clear the Preferences, flashed the sketch, flashed my secrets.json (LoRaWAN credentials) - and it worked! (17 uplink frames without any errors) I have no idea what was wrong before, but I suspect that the Preferences had not been cleared properly. |
@StevenCellist No, unfortunately the problem has not been solved. Logfile: Source code: |
From the log:
Is your radio asleep maybe? The channels are definitely available, so that is quite weird. |
Hmmm I have a suspicion. I hope to have a look soon. |
As I don't have the time to scan your full project: do you have ADR enabled? I expect it is disabled, right? |
I don't call |
I don't think so - I don't put it into sleep mode between |
The problem at hand is that the channel mask is either not stored correctly before going into deepsleep, or not being restored corrected after coming back from deepsleep. As you can see, the command is full of
It should be either With the conference tomorrow I don't have time to investigate now; I have verified that session restore works just before the release so this is a bit weird. But may be a bug after all. |
Would it be helpful if I put some debug printing of the channel mask into |
Yes, as well as the memcpy into the |
Could this (the template type in In
In
|
That's an interesting typo, but this |
I don't understand this entirely, but I'd say that this data is not stored in |
MAC commands are stored in-progress in |
I hope this is correct:
|
Here is a new logfile: |
See also: radiolib-org/radiolib-persistence#6 |
In your latest logfile, all uplinks succeed and there is no error at all. So that is interesting...? |
|
I agree that that is weird, but that is not a problem at that point in the code (yeah I know, not clear to a user). |
Here we go:
|
I have a strong suspicion but missing the log from the join leading up to the failure. If you can catch a complete cycle that would be perfect - the logging is awesome now - and that would likely confirm my suspicion. I don't have time to test myself yet, that would be around the weekend / early next week probably, in case you aren't in a position to continue the debugging. |
I have prepended the preceding cycle to my previous post. I don't think I can do much to debug this myself. |
Thanks for the complete log, that confirms my suspicion - it's a bug in RadioLib where it doesn't do the right thing until an ADR downlink is received. Today another The Things Conference day, but I should be able to come up with something fairly soon. Will see if it's going to be a bugfix release or a warning for users to cherry-pick the fix locally. |
Enjoy the conference! |
@matthias-bs thanks, and fixed in jgromes/RadioLib@5d076f6 |
@StevenCellist Thanks a lot! Seems to be working now! |
Hi @matthias-bs, just opening this so you are aware of the update to RadioLib 7.0 with some breaking changes. Most notably,
uplink()
anddownlink()
are now replaced by a singlesendReceive()
which may return a positive value when downlink is received or 0 when no downlink is received. Also, some of the return code names have been updated. There are a few more changes - I suggest taking another look at the examples provided in RadioLib (as well as the README in examples/LoRaWAN - v1.0.4 is now also officially supported).Feel free to close this at any moment, just a heads-up.
The text was updated successfully, but these errors were encountered: