Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean values don't get imported correctly #11

Open
aryehraber opened this issue Jun 17, 2020 · 1 comment
Open

Boolean values don't get imported correctly #11

aryehraber opened this issue Jun 17, 2020 · 1 comment

Comments

@aryehraber
Copy link
Contributor

aryehraber commented Jun 17, 2020 •
edited
Loading

Hit this earlier today, just opening issues so I don't forget to PR fixes 😅

TL;DR: true values get exported as '1' and false values get exported as (nothing). This results in incorrect values once imported again.

Will PR soon!
@mattias-persson
Copy link
Owner

Good stuff, keep 'em coming 😄

aryehraber added a commit to aryehraber/statamic-translation-manager that referenced this issue Jun 18, 2020
@aryehraber
Cast booleans back at import (closes mattias-persson#11)
c55da38
@aryehraber aryehraber mentioned this issue Jun 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aryehraber @mattias-persson