Deprecate NSUITextStorageEditActions

mattmassicotte · Mar 30, 2024 · 1390ba9 · 1390ba9
1 parent f6f9660
commit 1390ba9
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -58,7 +58,6 @@ NSUIResponder
 NSUIStackView
 NSUIStoryboard
 NSUITapGestureRecognizer
-NSUITextStorageEditActions
 NSUITextField
 NSUITextFieldDelegate
 NSUITextView

diff --git a/Sources/NSUI/TextView.swift b/Sources/NSUI/TextView.swift
@@ -1,14 +1,15 @@
 #if canImport(AppKit) && !targetEnvironment(macCatalyst)
 import AppKit
 
-public extension NSTextStorage {
-	typealias EditActions = NSTextStorageEditActions
+extension NSTextStorage {
+	public typealias EditActions = NSTextStorageEditActions
 }
 
+@available(*, deprecated, renamed: "NSTextStorage.EditActions")
 public typealias NSUITextStorageEditActions = NSTextStorageEditActions
 
-public extension NSTextView {
-	var text: String {
+extension NSTextView {
+	public var text: String {
 		get { return string }
 		set { string = newValue }
 	}
@@ -17,6 +18,7 @@ public extension NSTextView {
 #elseif canImport(UIKit)
 import UIKit
 
+@available(*, deprecated, renamed: "NSTextStorage.EditActions")
 public typealias NSUITextStorageEditActions = NSTextStorage.EditActions
 
 #endif
diff --git a/Tests/NSUITests/TextViewTests.swift b/Tests/NSUITests/TextViewTests.swift
@@ -1,5 +1,14 @@
 import XCTest
-@testable import NSUI
+import NSUI
+
+final class StorageDelegate: NSObject, NSTextStorageDelegate {
+	func textStorage(_ textStorage: NSTextStorage, willProcessEditing editedMask: NSTextStorage.EditActions, range editedRange: NSRange, changeInLength delta: Int) {
+
+	}
+
+	func textStorage(_ textStorage: NSTextStorage, didProcessEditing editedMask: NSTextStorage.EditActions, range editedRange: NSRange, changeInLength delta: Int) {
+	}
+}
 
 final class TextViewTests: XCTestCase {
 	@MainActor
@@ -13,7 +22,7 @@ final class TextViewTests: XCTestCase {
 
 	@MainActor
 	func testEditActions() throws {
-		let edit = NSUITextStorageEditActions.editedAttributes
+		let edit = NSTextStorage.EditActions.editedAttributes
 
 		XCTAssertTrue(edit.contains(.editedAttributes))
 	}