Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonApi request handlers: allow for non-included relationships #4

Open
maurei opened this issue Sep 28, 2018 · 0 comments
Open

JsonApi request handlers: allow for non-included relationships #4

maurei opened this issue Sep 28, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@maurei
Copy link
Owner

maurei commented Sep 28, 2018

Given the following models

 @Model()
export class B extends Resource {
	@Field()
	public id: string;
 }
@Model()
export class A extends Resource {
	@Field()
	public id: string;
	@ToOne()
	public toOneB: ToOneRelation<A,B>;
 }

Then, given a JSON API response

Allow for

{
  "data": [
    {
      "type": "A",
      "id": "1",
      "attributes": {},
      "relationships": {
        "toOneB": {
          "data": {
            "type": "B",
            "id": "100"
          }
        }
      }
    }
  ],
  "included": [
    {
      "type": "B",
      "id": "100",
      "attributes": {}
    }
  ]
}

will work, but

{
  "data": [
    {
      "type": "A",
      "id": "1",
      "attributes": {},
      "relationships": {
        "toOneB": {
          "data": {
            "type": "B",
            "id": "100"
          }
        }
      }
    }
  ]
}

will throw an error (expected key toOneB). This should not be the case.

@maurei maurei added the bug Something isn't working label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant