Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use channel's display_name instead of name #37

Open
MedicMomcilo opened this issue Aug 27, 2016 · 17 comments
Open

Use channel's display_name instead of name #37

MedicMomcilo opened this issue Aug 27, 2016 · 17 comments

Comments

@MedicMomcilo
Copy link

It would be awesome if you could substitute API output of channel.name with channel.display_name.
This is more prettier form and can have capital letters.

@RaphaelRochet
Copy link
Collaborator

Is there really any difference ?

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

Currently we don't even use channel.name either, I think. We use the string the user enters in the settings. And I think we've been consistent doing it this way.

@RaphaelRochet
Copy link
Collaborator

In fact we use streamer name and not channel name. But I wonder if a user can have multiple channels, or at least rename its channel ?

@MedicMomcilo
Copy link
Author

There is a difference. Lot of streamers to use first letter capital, and some other capitalisation:
Sudoshred,
MANvsGAME,
Squirrel,
iJevin,
LIRIK,
...

Everything else in extension popup menu looks beautiful except channel names which are all lowercase.

@RaphaelRochet
Copy link
Collaborator

RaphaelRochet commented Aug 27, 2016

If you enter correct capitalisation when adding streamers, it will be displayed with capitalisation. (Did you use followed import ?)

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

except channel names which are all lowercase.

Again, we respect the capitalization that was entered by the user in the options menu and nothing else. Currently, if you do use capital letters in the options menu streamer list, your streamers will be capitalized the same way.

@MedicMomcilo
Copy link
Author

MedicMomcilo commented Aug 27, 2016

I just did import and everything was lowercase, I am not really sure that I understand your question. Also, now I see that if I manually add with capitalisation, it will be shown that way.

So, I guess it should be importing capitalised names by default.

Now that I think about this, does this means that import is not being done constantly? As in, if I follow channel through browser, I would have to manually add it to the list?

@RaphaelRochet
Copy link
Collaborator

Okay, I just push a tiny fix for the import from twitch account function, so that it will use proper capitalisation. Can you give it a try ?
(Commit 19b30d9)

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

does this means that import is not being done constantly?

Correct.

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

@RaphaelRochet Please revert 19b30d9

This doesn't work. We really have to use the name and not the display name.

bildschirmfoto von 2016-08-27 17-28-23

The name is xargon0731 and we can query the channel by this name. The display_name is \u6bba\u6897

@RaphaelRochet
Copy link
Collaborator

Okay, this commit never existed.

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

So as I see it, we could actually use the display_name when we, you know, display the name. The twitch ui probably checks whether those are basically the same and shows the name in brackets if they aren't (for us stupid westerners).

We could do something similar.

@MedicMomcilo
Copy link
Author

Sounds perfect

@MedicMomcilo
Copy link
Author

Maybe there could be an option to set username for importing followers that would be refreshed always (or on startup, or daily, or whatever :) )?
This way it would really feel like fully integrated.

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

This needs some checking because we have to, I think, unescape the utf-8 characters. I don't know how this is handled with gtk and stuff.

@maweki
Copy link
Owner

maweki commented Aug 27, 2016

Maybe there could be an option to set username for importing followers that would be refreshed always (or on startup, or daily, or whatever :) )?

We thought about this before but with the current data model we're not able to track unfollows so there's no real way to "fully integrate" without storing more information about the streamers than their names. You can open a new ticket for this but it won't be done before we do something about the streamer-object issue.

@MedicMomcilo
Copy link
Author

Yes, but if we have a list of streamers such as:
streamerA
streamerB
[userX]

The final list to be checked for live streams could be import of userX with addition of streamerA and streamerB.
This is of course uneducated guess as my extension for this purpose is a horrible hacky mess compared to yours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants