-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use channel's display_name instead of name #37
Comments
Is there really any difference ? |
Currently we don't even use channel.name either, I think. We use the string the user enters in the settings. And I think we've been consistent doing it this way. |
In fact we use streamer name and not channel name. But I wonder if a user can have multiple channels, or at least rename its channel ? |
There is a difference. Lot of streamers to use first letter capital, and some other capitalisation: Everything else in extension popup menu looks beautiful except channel names which are all lowercase. |
If you enter correct capitalisation when adding streamers, it will be displayed with capitalisation. (Did you use followed import ?) |
Again, we respect the capitalization that was entered by the user in the options menu and nothing else. Currently, if you do use capital letters in the options menu streamer list, your streamers will be capitalized the same way. |
I just did import and everything was lowercase, I am not really sure that I understand your question. Also, now I see that if I manually add with capitalisation, it will be shown that way. So, I guess it should be importing capitalised names by default. Now that I think about this, does this means that import is not being done constantly? As in, if I follow channel through browser, I would have to manually add it to the list? |
Okay, I just push a tiny fix for the import from twitch account function, so that it will use proper capitalisation. Can you give it a try ? |
Correct. |
@RaphaelRochet Please revert 19b30d9 This doesn't work. We really have to use the name and not the display name. The |
Okay, this commit never existed. |
So as I see it, we could actually use the We could do something similar. |
Sounds perfect |
Maybe there could be an option to set username for importing followers that would be refreshed always (or on startup, or daily, or whatever :) )? |
This needs some checking because we have to, I think, unescape the utf-8 characters. I don't know how this is handled with gtk and stuff. |
We thought about this before but with the current data model we're not able to track unfollows so there's no real way to "fully integrate" without storing more information about the streamers than their names. You can open a new ticket for this but it won't be done before we do something about the streamer-object issue. |
Yes, but if we have a list of streamers such as: The final list to be checked for live streams could be import of userX with addition of streamerA and streamerB. |
It would be awesome if you could substitute API output of channel.name with channel.display_name.
This is more prettier form and can have capital letters.
The text was updated successfully, but these errors were encountered: